tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

clocksource/drivers/imx: Fix -Wunused-but-set-variable warning

All warnings (new ones prefixed by >>):

drivers/clocksource/timer-imx-gpt.c: In function 'mxc_timer_interrupt':
>> drivers/clocksource/timer-imx-gpt.c:279:18: warning: variable 'tstat' set but not used [-Wunused-but-set-variable]
279 | uint32_t tstat;
| ^~~~~

vim +/tstat +279 drivers/clocksource/timer-imx-gpt.c

The change remove the tstats assignment but not the reading of the
register, assuming the register may be a ROR (Reset On Read) which
happens in the driver's interrupt registers.

Fixes: df181e382816 ("clocksource/drivers/imx-gpt: Add support for ARM64")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202312231803.XzPddRa5-lkp@intel.com/
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20231227143546.2823683-1-daniel.lezcano@linaro.org

Daniel Lezcano bf3159c0 71fee48f

+1 -2
+1 -2
drivers/clocksource/timer-imx-gpt.c
··· 258 258 { 259 259 struct clock_event_device *ced = dev_id; 260 260 struct imx_timer *imxtm = to_imx_timer(ced); 261 - uint32_t tstat; 262 261 263 - tstat = readl_relaxed(imxtm->base + imxtm->gpt->reg_tstat); 262 + readl_relaxed(imxtm->base + imxtm->gpt->reg_tstat); 264 263 265 264 imxtm->gpt->gpt_irq_acknowledge(imxtm); 266 265