Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

scsi: ufs: core: Discard pm_runtime_put() return values

The ufshcd driver defines ufshcd_rpm_put() to return an int, but that
return value is never used. It also passes the return value of
pm_runtime_put() to the caller which is not very useful.

Returning an error code from pm_runtime_put() merely means that it has
not queued up a work item to check whether or not the device can be
suspended and there are many perfectly valid situations in which that
can happen, like after writing "on" to the devices' runtime PM "control"
attribute in sysfs for one example.

Modify ufshcd_rpm_put() to discard the pm_runtime_put() return value
and change its return type to void.

No intentional functional impact.

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Link: https://patch.msgid.link/2781685.BddDVKsqQX@rafael.j.wysocki

+2 -2
+2 -2
drivers/ufs/core/ufshcd-priv.h
··· 348 348 return pm_runtime_resume(&hba->ufs_device_wlun->sdev_gendev); 349 349 } 350 350 351 - static inline int ufshcd_rpm_put(struct ufs_hba *hba) 351 + static inline void ufshcd_rpm_put(struct ufs_hba *hba) 352 352 { 353 - return pm_runtime_put(&hba->ufs_device_wlun->sdev_gendev); 353 + pm_runtime_put(&hba->ufs_device_wlun->sdev_gendev); 354 354 } 355 355 356 356 /**