tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: phy: micrel: Fix lan8814_config_init

The blamed commit introduced the function lanphy_modify_page_reg which
as name suggests it, it modifies the registers. In the same commit we
have started to use this function inside the drivers. The problem is
that in the function lan8814_config_init we passed the wrong page number
when disabling the aneg towards host side. We passed extended page number
4(LAN8814_PAGE_COMMON_REGS) instead of extended page
5(LAN8814_PAGE_PORT_REGS)

Fixes: a0de636ed7a264 ("net: phy: micrel: Introduce lanphy_modify_page_reg")
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250925064702.3906950-1-horatiu.vultur@microchip.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Horatiu Vultur and committed by
Jakub Kicinski bf91f4bc 105ce7ad

+1 -1
+1 -1
drivers/net/phy/micrel.c
··· 4367 4367 LAN8814_QSGMII_SOFT_RESET_BIT); 4368 4368 4369 4369 /* Disable ANEG with QSGMII PCS Host side */ 4370 - lanphy_modify_page_reg(phydev, LAN8814_PAGE_COMMON_REGS, 4370 + lanphy_modify_page_reg(phydev, LAN8814_PAGE_PORT_REGS, 4371 4371 LAN8814_QSGMII_PCS1G_ANEG_CONFIG, 4372 4372 LAN8814_QSGMII_PCS1G_ANEG_CONFIG_ANEG_ENA, 4373 4373 0);