Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
padata: Constify padata_sysfs_entry structs
These structs are never modified.
To prevent malicious or accidental modifications due to bugs,
mark them as const.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
authored by
Thomas Weißschuh
and committed by
Herbert Xu
c1b12cd9
a3f8e009
+11
-11
+11
-11
kernel/padata.c
+11
-11
kernel/padata.c
···
819
819
#define kobj2pinst(_kobj) \
820
820
container_of(_kobj, struct padata_instance, kobj)
821
821
#define attr2pentry(_attr) \
822
-
container_of(_attr, struct padata_sysfs_entry, attr)
822
+
container_of_const(_attr, struct padata_sysfs_entry, attr)
823
823
824
824
static void padata_sysfs_release(struct kobject *kobj)
825
825
{
···
829
829
830
830
struct padata_sysfs_entry {
831
831
struct attribute attr;
832
-
ssize_t (*show)(struct padata_instance *, struct attribute *, char *);
833
-
ssize_t (*store)(struct padata_instance *, struct attribute *,
832
+
ssize_t (*show)(struct padata_instance *, const struct attribute *, char *);
833
+
ssize_t (*store)(struct padata_instance *, const struct attribute *,
834
834
const char *, size_t);
835
835
};
836
836
837
837
static ssize_t show_cpumask(struct padata_instance *pinst,
838
-
struct attribute *attr, char *buf)
838
+
const struct attribute *attr, char *buf)
839
839
{
840
840
struct cpumask *cpumask;
841
841
ssize_t len;
···
853
853
}
854
854
855
855
static ssize_t store_cpumask(struct padata_instance *pinst,
856
-
struct attribute *attr,
856
+
const struct attribute *attr,
857
857
const char *buf, size_t count)
858
858
{
859
859
cpumask_var_t new_cpumask;
···
880
880
}
881
881
882
882
#define PADATA_ATTR_RW(_name, _show_name, _store_name) \
883
-
static struct padata_sysfs_entry _name##_attr = \
883
+
static const struct padata_sysfs_entry _name##_attr = \
884
884
__ATTR(_name, 0644, _show_name, _store_name)
885
-
#define PADATA_ATTR_RO(_name, _show_name) \
886
-
static struct padata_sysfs_entry _name##_attr = \
885
+
#define PADATA_ATTR_RO(_name, _show_name) \
886
+
static const struct padata_sysfs_entry _name##_attr = \
887
887
__ATTR(_name, 0400, _show_name, NULL)
888
888
889
889
PADATA_ATTR_RW(serial_cpumask, show_cpumask, store_cpumask);
···
894
894
* serial_cpumask [RW] - cpumask for serial workers
895
895
* parallel_cpumask [RW] - cpumask for parallel workers
896
896
*/
897
-
static struct attribute *padata_default_attrs[] = {
897
+
static const struct attribute *const padata_default_attrs[] = {
898
898
&serial_cpumask_attr.attr,
899
899
¶llel_cpumask_attr.attr,
900
900
NULL,
···
904
904
static ssize_t padata_sysfs_show(struct kobject *kobj,
905
905
struct attribute *attr, char *buf)
906
906
{
907
+
const struct padata_sysfs_entry *pentry;
907
908
struct padata_instance *pinst;
908
-
struct padata_sysfs_entry *pentry;
909
909
ssize_t ret = -EIO;
910
910
911
911
pinst = kobj2pinst(kobj);
···
919
919
static ssize_t padata_sysfs_store(struct kobject *kobj, struct attribute *attr,
920
920
const char *buf, size_t count)
921
921
{
922
+
const struct padata_sysfs_entry *pentry;
922
923
struct padata_instance *pinst;
923
-
struct padata_sysfs_entry *pentry;
924
924
ssize_t ret = -EIO;
925
925
926
926
pinst = kobj2pinst(kobj);