Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

s390/qeth: convert sysfs snprintf to sysfs_emit

Follow the advice of the Documentation/filesystems/sysfs.rst
and show() should only use sysfs_emit() or sysfs_emit_at()
when formatting the value to be returned to user space.

Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Xuezhi Zhang and committed by
David S. Miller
c2052189 0e3d1835

+6 -6
+6 -6
drivers/s390/net/qeth_core_sys.c
··· 410 410 411 411 switch (card->options.isolation) { 412 412 case ISOLATION_MODE_NONE: 413 - return snprintf(buf, 6, "%s\n", ATTR_QETH_ISOLATION_NONE); 413 + return sysfs_emit(buf, "%s\n", ATTR_QETH_ISOLATION_NONE); 414 414 case ISOLATION_MODE_FWD: 415 - return snprintf(buf, 9, "%s\n", ATTR_QETH_ISOLATION_FWD); 415 + return sysfs_emit(buf, "%s\n", ATTR_QETH_ISOLATION_FWD); 416 416 case ISOLATION_MODE_DROP: 417 - return snprintf(buf, 6, "%s\n", ATTR_QETH_ISOLATION_DROP); 417 + return sysfs_emit(buf, "%s\n", ATTR_QETH_ISOLATION_DROP); 418 418 default: 419 - return snprintf(buf, 5, "%s\n", "N/A"); 419 + return sysfs_emit(buf, "%s\n", "N/A"); 420 420 } 421 421 } 422 422 ··· 500 500 struct qeth_card *card = dev_get_drvdata(dev); 501 501 502 502 if (card->info.hwtrap) 503 - return snprintf(buf, 5, "arm\n"); 503 + return sysfs_emit(buf, "arm\n"); 504 504 else 505 - return snprintf(buf, 8, "disarm\n"); 505 + return sysfs_emit(buf, "disarm\n"); 506 506 } 507 507 508 508 static ssize_t qeth_hw_trap_store(struct device *dev,