tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/virtio: Fix NULL vs IS_ERR checking in virtio_gpu_object_shmem_init

Since drm_prime_pages_to_sg() function return error pointers.
The drm_gem_shmem_get_sg_table() function returns error pointers too.
Using IS_ERR() to check the return value to fix this.

Fixes: 2f2aa13724d5 ("drm/virtio: move virtio_gpu_mem_entry initialization to new function")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20220602104223.54527-1-linmq006@gmail.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

authored by

Miaoqian Lin and committed by
Gerd Hoffmann c2496873 9e9fa6a9

+2 -2
+2 -2
drivers/gpu/drm/virtio/virtgpu_object.c
··· 168 168 * since virtio_gpu doesn't support dma-buf import from other devices. 169 169 */ 170 170 shmem->pages = drm_gem_shmem_get_sg_table(&bo->base); 171 - if (!shmem->pages) { 171 + if (IS_ERR(shmem->pages)) { 172 172 drm_gem_shmem_unpin(&bo->base); 173 - return -EINVAL; 173 + return PTR_ERR(shmem->pages); 174 174 } 175 175 176 176 if (use_dma_api) {