Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/client: Create client buffers with drm_client_buffer_create_dumb()
Rename drm_client_framebuffer_create() to drm_client_buffer_create_dump()
and adapt callers. The new name reflects the function's purpose. Using
dumb buffers is the easiest way for creating a GEM buffer in a drivers-
independent way.
There's also drm_client_buffer_create(), which creates the client buffer
from a preexisting buffer object. This helper can be exported for drivers
that create their own GEM buffer object.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Tested-by: Francesco Valla <francesco@valla.it>
Link: https://patch.msgid.link/20251027121042.143588-7-tzimmermann@suse.de
+8
-8
+1
-1
drivers/gpu/drm/clients/drm_log.c
+1
-1
drivers/gpu/drm/clients/drm_log.c
···
204
204
if (format == DRM_FORMAT_INVALID)
205
205
return -EINVAL;
206
206
207
-
scanout->buffer = drm_client_framebuffer_create(client, width, height, format);
207
+
scanout->buffer = drm_client_buffer_create_dumb(client, width, height, format);
208
208
if (IS_ERR(scanout->buffer)) {
209
209
drm_warn(client->dev, "drm_log can't create framebuffer %d %d %p4cc\n",
210
210
width, height, &format);
+3
-3
drivers/gpu/drm/drm_client.c
+3
-3
drivers/gpu/drm/drm_client.c
···
377
377
EXPORT_SYMBOL(drm_client_buffer_vunmap);
378
378
379
379
/**
380
-
* drm_client_framebuffer_create - Create a client framebuffer
380
+
* drm_client_buffer_create_dumb - Create a client buffer backed by a dumb buffer
381
381
* @client: DRM client
382
382
* @width: Framebuffer width
383
383
* @height: Framebuffer height
···
391
391
* Pointer to a client buffer or an error pointer on failure.
392
392
*/
393
393
struct drm_client_buffer *
394
-
drm_client_framebuffer_create(struct drm_client_dev *client, u32 width, u32 height, u32 format)
394
+
drm_client_buffer_create_dumb(struct drm_client_dev *client, u32 width, u32 height, u32 format)
395
395
{
396
396
const struct drm_format_info *info = drm_format_info(format);
397
397
struct drm_device *dev = client->dev;
···
427
427
drm_mode_destroy_dumb(client->dev, dumb_args.handle, client->file);
428
428
return ERR_PTR(ret);
429
429
}
430
-
EXPORT_SYMBOL(drm_client_framebuffer_create);
430
+
EXPORT_SYMBOL(drm_client_buffer_create_dumb);
431
431
432
432
/**
433
433
* drm_client_framebuffer_flush - Manually flush client framebuffer
+1
-1
drivers/gpu/drm/drm_fbdev_dma.c
+1
-1
drivers/gpu/drm/drm_fbdev_dma.c
···
281
281
282
282
format = drm_driver_legacy_fb_format(dev, sizes->surface_bpp,
283
283
sizes->surface_depth);
284
-
buffer = drm_client_framebuffer_create(client, sizes->surface_width,
284
+
buffer = drm_client_buffer_create_dumb(client, sizes->surface_width,
285
285
sizes->surface_height, format);
286
286
if (IS_ERR(buffer))
287
287
return PTR_ERR(buffer);
+1
-1
drivers/gpu/drm/drm_fbdev_shmem.c
+1
-1
drivers/gpu/drm/drm_fbdev_shmem.c
···
147
147
sizes->surface_bpp);
148
148
149
149
format = drm_driver_legacy_fb_format(dev, sizes->surface_bpp, sizes->surface_depth);
150
-
buffer = drm_client_framebuffer_create(client, sizes->surface_width,
150
+
buffer = drm_client_buffer_create_dumb(client, sizes->surface_width,
151
151
sizes->surface_height, format);
152
152
if (IS_ERR(buffer))
153
153
return PTR_ERR(buffer);
+1
-1
drivers/gpu/drm/drm_fbdev_ttm.c
+1
-1
drivers/gpu/drm/drm_fbdev_ttm.c
···
187
187
188
188
format = drm_driver_legacy_fb_format(dev, sizes->surface_bpp,
189
189
sizes->surface_depth);
190
-
buffer = drm_client_framebuffer_create(client, sizes->surface_width,
190
+
buffer = drm_client_buffer_create_dumb(client, sizes->surface_width,
191
191
sizes->surface_height, format);
192
192
if (IS_ERR(buffer))
193
193
return PTR_ERR(buffer);
+1
-1
include/drm/drm_client.h
+1
-1
include/drm/drm_client.h
···
194
194
};
195
195
196
196
struct drm_client_buffer *
197
-
drm_client_framebuffer_create(struct drm_client_dev *client, u32 width, u32 height, u32 format);
197
+
drm_client_buffer_create_dumb(struct drm_client_dev *client, u32 width, u32 height, u32 format);
198
198
void drm_client_buffer_delete(struct drm_client_buffer *buffer);
199
199
int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect);
200
200
int drm_client_buffer_vmap_local(struct drm_client_buffer *buffer,