tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

spi: Drop dev_pm_domain_detach() call

Starting with commit f99508074e78 ("PM: domains: Detach on
device_unbind_cleanup()"), there is no longer a need to call
dev_pm_domain_detach() in the bus remove function. The
device_unbind_cleanup() function now handles this to avoid
invoking devres cleanup handlers while the PM domain is
powered off, which could otherwise lead to failures as
described in the above-mentioned commit.

Drop the explicit dev_pm_domain_detach() call and rely instead
on the flags passed to dev_pm_domain_attach() to power off the
domain.

Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Message-ID: <20250827101612.928008-1-claudiu.beznea.uj@bp.renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Claudiu Beznea and committed by
Mark Brown c42e36a4 b875b970

+3 -7
+3 -7
drivers/spi/spi.c
··· 427 427 if (spi->irq < 0) 428 428 spi->irq = 0; 429 429 430 - ret = dev_pm_domain_attach(dev, PD_FLAG_ATTACH_POWER_ON); 430 + ret = dev_pm_domain_attach(dev, PD_FLAG_ATTACH_POWER_ON | 431 + PD_FLAG_DETACH_POWER_OFF); 431 432 if (ret) 432 433 return ret; 433 434 434 - if (sdrv->probe) { 435 + if (sdrv->probe) 435 436 ret = sdrv->probe(spi); 436 - if (ret) 437 - dev_pm_domain_detach(dev, true); 438 - } 439 437 440 438 return ret; 441 439 } ··· 444 446 445 447 if (sdrv->remove) 446 448 sdrv->remove(to_spi_device(dev)); 447 - 448 - dev_pm_domain_detach(dev, true); 449 449 } 450 450 451 451 static void spi_shutdown(struct device *dev)