tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ASoC: sma1307: fix uninitialized variable refence

When firmware loading is disabled, gcc warns that the local
'fw' variable fails to get initialized:

sound/soc/codecs/sma1307.c: In function 'sma1307_setting_loaded.isra':
sound/soc/codecs/sma1307.c:1717:12: error: 'fw' is used uninitialized [-Werror=uninitialized]
1717 | if (!fw) {
| ^
sound/soc/codecs/sma1307.c:1712:32: note: 'fw' was declared here
1712 | const struct firmware *fw;

Check the return code from request_firmware() to ensure that the
firmware is correctly set, and drop the incorrect release_firmware()
on that uninitialized data.

Fixes: 576c57e6b4c1 ("ASoC: sma1307: Add driver for Iron Device SMA1307")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://patch.msgid.link/20241113175734.2443315-1-arnd@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Arnd Bergmann and committed by
Mark Brown c48a4497 07db6d5e

+5 -5
+5 -5
sound/soc/codecs/sma1307.c
··· 1711 1711 { 1712 1712 const struct firmware *fw; 1713 1713 int *data, size, offset, num_mode; 1714 + int ret; 1714 1715 1715 - request_firmware(&fw, file, sma1307->dev); 1716 + ret = request_firmware(&fw, file, sma1307->dev); 1716 1717 1717 - if (!fw) { 1718 - dev_err(sma1307->dev, "%s: failed to read \"%s\"\n", 1719 - __func__, setting_file); 1720 - release_firmware(fw); 1718 + if (ret) { 1719 + dev_err(sma1307->dev, "%s: failed to read \"%s\": %pe\n", 1720 + __func__, setting_file, ERR_PTR(ret)); 1721 1721 sma1307->set.status = false; 1722 1722 return; 1723 1723 } else if ((fw->size) < SMA1307_SETTING_HEADER_SIZE) {