Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Input: wm97xx-core - convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20230920125829.1478827-53-u.kleine-koenig@pengutronix.de
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

authored by

Uwe Kleine-König and committed by
Dmitry Torokhov
c50fdc48 33984b4f

+2 -4
+2 -4
drivers/input/touchscreen/wm97xx-core.c
··· 756 756 return ret; 757 757 } 758 758 759 - static int wm97xx_mfd_remove(struct platform_device *pdev) 759 + static void wm97xx_mfd_remove(struct platform_device *pdev) 760 760 { 761 761 wm97xx_remove(&pdev->dev); 762 - 763 - return 0; 764 762 } 765 763 766 764 static int wm97xx_suspend(struct device *dev) ··· 876 878 .pm = pm_sleep_ptr(&wm97xx_pm_ops), 877 879 }, 878 880 .probe = wm97xx_mfd_probe, 879 - .remove = wm97xx_mfd_remove, 881 + .remove_new = wm97xx_mfd_remove, 880 882 }; 881 883 882 884 static int __init wm97xx_init(void)