Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/msm/dpu: change ib values to u32
The IB values in core_perf calculations (max_per_pipe_ib,
fix_core_ib_vote) are expressed in KBps and are passed to icc_set_bw
without additional division. Change type of those values to u32.
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/636061/
Link: https://lore.kernel.org/r/20250209-dpu-perf-rework-v5-3-87e936cf3004@linaro.org
+6
-6
+2
-2
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
+2
-2
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
···
135
135
}
136
136
137
137
DRM_DEBUG_ATOMIC(
138
-
"crtc=%d clk_rate=%llu core_ib=%llu core_ab=%llu\n",
138
+
"crtc=%d clk_rate=%llu core_ib=%u core_ab=%llu\n",
139
139
crtc->base.id, perf->core_clk_rate,
140
140
perf->max_per_pipe_ib, perf->bw_ctl);
141
141
}
···
477
477
(u32 *)perf, &dpu_core_perf_mode_fops);
478
478
debugfs_create_u64("fix_core_clk_rate", 0600, entry,
479
479
&perf->fix_core_clk_rate);
480
-
debugfs_create_u64("fix_core_ib_vote", 0600, entry,
480
+
debugfs_create_u32("fix_core_ib_vote", 0600, entry,
481
481
&perf->fix_core_ib_vote);
482
482
debugfs_create_u64("fix_core_ab_vote", 0600, entry,
483
483
&perf->fix_core_ab_vote);
+3
-3
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h
+3
-3
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h
···
19
19
* @core_clk_rate: core clock rate request
20
20
*/
21
21
struct dpu_core_perf_params {
22
-
u64 max_per_pipe_ib;
22
+
u32 max_per_pipe_ib;
23
23
u64 bw_ctl;
24
24
u64 core_clk_rate;
25
25
};
···
40
40
* @perf_tune: debug control for performance tuning
41
41
* @enable_bw_release: debug control for bandwidth release
42
42
* @fix_core_clk_rate: fixed core clock request in Hz used in mode 2
43
-
* @fix_core_ib_vote: fixed core ib vote in bps used in mode 2
43
+
* @fix_core_ib_vote: fixed core ib vote in KBps used in mode 2
44
44
* @fix_core_ab_vote: fixed core ab vote in bps used in mode 2
45
45
*/
46
46
struct dpu_core_perf {
···
50
50
struct dpu_core_perf_tune perf_tune;
51
51
u32 enable_bw_release;
52
52
u64 fix_core_clk_rate;
53
-
u64 fix_core_ib_vote;
53
+
u32 fix_core_ib_vote;
54
54
u64 fix_core_ab_vote;
55
55
};
56
56
+1
-1
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
+1
-1
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
···
1680
1680
seq_printf(s, "core_clk_rate: %llu\n",
1681
1681
dpu_crtc->cur_perf.core_clk_rate);
1682
1682
seq_printf(s, "bw_ctl: %llu\n", dpu_crtc->cur_perf.bw_ctl);
1683
-
seq_printf(s, "max_per_pipe_ib: %llu\n",
1683
+
seq_printf(s, "max_per_pipe_ib: %u\n",
1684
1684
dpu_crtc->cur_perf.max_per_pipe_ib);
1685
1685
1686
1686
return 0;