tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

iio: light: veml6030: fix IIO device retrieval from embedded device

The dev pointer that is received as an argument in the
in_illuminance_period_available_show function references the device
embedded in the IIO device, not in the i2c client.

dev_to_iio_dev() must be used to accessthe right data. The current
implementation leads to a segmentation fault on every attempt to read
the attribute because indio_dev gets a NULL assignment.

This bug has been present since the first appearance of the driver,
apparently since the last version (V6) before getting applied. A
constant attribute was used until then, and the last modifications might
have not been tested again.

Cc: stable@vger.kernel.org
Fixes: 7b779f573c48 ("iio: light: add driver for veml6030 ambient light sensor")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://patch.msgid.link/20240913-veml6035-v1-3-0b09c0c90418@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Javier Carrasco and committed by
Jonathan Cameron c7c44e57 db9795a4

+1 -2
+1 -2
drivers/iio/light/veml6030.c
··· 99 99 static ssize_t in_illuminance_period_available_show(struct device *dev, 100 100 struct device_attribute *attr, char *buf) 101 101 { 102 + struct veml6030_data *data = iio_priv(dev_to_iio_dev(dev)); 102 103 int ret, reg, x; 103 - struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev)); 104 - struct veml6030_data *data = iio_priv(indio_dev); 105 104 106 105 ret = regmap_read(data->regmap, VEML6030_REG_ALS_CONF, &reg); 107 106 if (ret) {