tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ep93xx: clock: Fix off by one in ep93xx_div_recalc_rate()

The psc->div[] array has psc->num_div elements. These values come from
when we call clk_hw_register_div(). It's adc_divisors and
ARRAY_SIZE(adc_divisors)) and so on. So this condition needs to be >=
instead of > to prevent an out of bounds read.

Fixes: 9645ccc7bd7a ("ep93xx: clock: convert in-place to COMMON_CLK")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Reviewed-by: Nikita Shubin <nikita.shubin@maquefel.me>
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Link: https://lore.kernel.org/r/1caf01ad4c0a8069535813c26c7f0b8ea011155e.camel@linaro.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

authored by

Dan Carpenter and committed by
Arnd Bergmann c7f06284 47ac09b9

+1 -1
+1 -1
arch/arm/mach-ep93xx/clock.c
··· 359 359 u32 val = __raw_readl(psc->reg); 360 360 u8 index = (val & psc->mask) >> psc->shift; 361 361 362 - if (index > psc->num_div) 362 + if (index >= psc->num_div) 363 363 return 0; 364 364 365 365 return DIV_ROUND_UP_ULL(parent_rate, psc->div[index]);