tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

bpf, selftests: Fix warning in snprintf_btf where system() call unchecked

On my systems system() calls are marked with warn_unused_result
apparently. So without error checking we get this warning,

./prog_tests/snprintf_btf.c:30:9: warning: ignoring return value
of ‘system’, declared with attribute warn_unused_result[-Wunused-result]

Also it seems like a good idea to check the return value anyways
to ensure ping exists even if its seems unlikely.

Fixes: 076a95f5aff2c ("selftests/bpf: Add bpf_snprintf_btf helper tests")
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/160141006897.25201.12095049414156293265.stgit@john-Precision-5820-Tower

authored by

John Fastabend and committed by
Alexei Starovoitov c810b31e 93b8713d

+3 -1
+3 -1
tools/testing/selftests/bpf/prog_tests/snprintf_btf.c
··· 27 27 goto cleanup; 28 28 29 29 /* generate receive event */ 30 - (void) system("ping -c 1 127.0.0.1 > /dev/null"); 30 + err = system("ping -c 1 127.0.0.1 > /dev/null"); 31 + if (CHECK(err, "system", "ping failed: %d\n", err)) 32 + goto cleanup; 31 33 32 34 if (bss->skip) { 33 35 printf("%s:SKIP:no __builtin_btf_type_id\n", __func__);