Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
powerpc/32: Drop unused grackle_set_stg()
The call to grackle_set_stg() ("Store Gathering") has always been inside
an #ifdef 0, since the code was first merged in v2.3.43pre7.
Apparently it was suspected of causing problems on some hardware so was
disabled. No one has ever proved otherwise so drop the code as unused
for now.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Bjorn Helgaas <helgaas@kernel.org>
Closes: https://lore.kernel.org/all/20231031145600.GA9161@bhelgaas/
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20231113051929.1952351-1-mpe@ellerman.id.au
-19
-19
arch/powerpc/sysdev/grackle.c
-19
arch/powerpc/sysdev/grackle.c
···
18
18
#define GRACKLE_CFA(b, d, o) (0x80 | ((b) << 8) | ((d) << 16) \
19
19
| (((o) & ~3) << 24))
20
20
21
-
#define GRACKLE_PICR1_STG 0x00000040
22
21
#define GRACKLE_PICR1_LOOPSNOOP 0x00000010
23
-
24
-
/* N.B. this is called before bridges is initialized, so we can't
25
-
use grackle_pcibios_{read,write}_config_dword. */
26
-
static inline void grackle_set_stg(struct pci_controller* bp, int enable)
27
-
{
28
-
unsigned int val;
29
-
30
-
out_be32(bp->cfg_addr, GRACKLE_CFA(0, 0, 0xa8));
31
-
val = in_le32(bp->cfg_data);
32
-
val = enable? (val | GRACKLE_PICR1_STG) :
33
-
(val & ~GRACKLE_PICR1_STG);
34
-
out_be32(bp->cfg_addr, GRACKLE_CFA(0, 0, 0xa8));
35
-
out_le32(bp->cfg_data, val);
36
-
(void)in_le32(bp->cfg_data);
37
-
}
38
22
39
23
static inline void grackle_set_loop_snoop(struct pci_controller *bp, int enable)
40
24
{
···
40
56
pci_add_flags(PCI_REASSIGN_ALL_BUS);
41
57
if (of_machine_is_compatible("AAPL,PowerBook1998"))
42
58
grackle_set_loop_snoop(hose, 1);
43
-
#if 0 /* Disabled for now, HW problems ??? */
44
-
grackle_set_stg(hose, 1);
45
-
#endif
46
59
}