tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

crypto: atmel-tdes - fix DMA sync direction

Before DMA output is consumed by the CPU, ->dma_addr_out must be synced
with dma_sync_single_for_cpu() instead of dma_sync_single_for_device().
Using the wrong direction can return stale cache data on non-coherent
platforms.

Fixes: 13802005d8f2 ("crypto: atmel - add Atmel DES/TDES driver")
Fixes: 1f858040c2f7 ("crypto: atmel-tdes - add support for latest release of the IP (0x700)")
Cc: stable@vger.kernel.org
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

Thorsten Blum and committed by
Herbert Xu c8a9a647 53770329

+4 -4
+4 -4
drivers/crypto/atmel-tdes.c
··· 294 294 dma_unmap_sg(dd->dev, dd->out_sg, 1, DMA_FROM_DEVICE); 295 295 dma_unmap_sg(dd->dev, dd->in_sg, 1, DMA_TO_DEVICE); 296 296 } else { 297 - dma_sync_single_for_device(dd->dev, dd->dma_addr_out, 298 - dd->dma_size, DMA_FROM_DEVICE); 297 + dma_sync_single_for_cpu(dd->dev, dd->dma_addr_out, 298 + dd->dma_size, DMA_FROM_DEVICE); 299 299 300 300 /* copy data */ 301 301 count = atmel_tdes_sg_copy(&dd->out_sg, &dd->out_offset, ··· 619 619 dma_unmap_sg(dd->dev, dd->out_sg, 1, DMA_FROM_DEVICE); 620 620 dma_unmap_sg(dd->dev, dd->in_sg, 1, DMA_TO_DEVICE); 621 621 } else { 622 - dma_sync_single_for_device(dd->dev, dd->dma_addr_out, 623 - dd->dma_size, DMA_FROM_DEVICE); 622 + dma_sync_single_for_cpu(dd->dev, dd->dma_addr_out, 623 + dd->dma_size, DMA_FROM_DEVICE); 624 624 625 625 /* copy data */ 626 626 count = atmel_tdes_sg_copy(&dd->out_sg, &dd->out_offset,