Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

hung_task: fix warnings caused by unaligned lock pointers

The blocker tracking mechanism assumes that lock pointers are at least
4-byte aligned to use their lower bits for type encoding.

However, as reported by Eero Tamminen, some architectures like m68k
only guarantee 2-byte alignment of 32-bit values. This breaks the
assumption and causes two related WARN_ON_ONCE checks to trigger.

To fix this, the runtime checks are adjusted to silently ignore any lock
that is not 4-byte aligned, effectively disabling the feature in such
cases and avoiding the related warnings.

Thanks to Geert Uytterhoeven for bisecting!

Link: https://lkml.kernel.org/r/20250909145243.17119-1-lance.yang@linux.dev
Fixes: e711faaafbe5 ("hung_task: replace blocker_mutex with encoded blocker")
Signed-off-by: Lance Yang <lance.yang@linux.dev>
Reported-by: Eero Tamminen <oak@helsinkinet.fi>
Closes: https://lore.kernel.org/lkml/CAMuHMdW7Ab13DdGs2acMQcix5ObJK0O2dG_Fxzr8_g58Rc1_0g@mail.gmail.com
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Anna Schumaker <anna.schumaker@oracle.com>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: Finn Thain <fthain@linux-m68k.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Joel Granados <joel.granados@kernel.org>
Cc: John Stultz <jstultz@google.com>
Cc: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Lance Yang <lance.yang@linux.dev>
Cc: Mingzhe Yang <mingzhe.yang@ly.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Tomasz Figa <tfiga@chromium.org>
Cc: Waiman Long <longman@redhat.com>
Cc: Will Deacon <will@kernel.org>
Cc: Yongliang Gao <leonylgao@tencent.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Lance Yang and committed by
Andrew Morton
c97513cd 3a866087

+5 -3
+5 -3
include/linux/hung_task.h
··· 20 20 * always zero. So we can use these bits to encode the specific blocking 21 21 * type. 22 22 * 23 + * Note that on architectures where this is not guaranteed, or for any 24 + * unaligned lock, this tracking mechanism is silently skipped for that 25 + * lock. 26 + * 23 27 * Type encoding: 24 28 * 00 - Blocked on mutex (BLOCKER_TYPE_MUTEX) 25 29 * 01 - Blocked on semaphore (BLOCKER_TYPE_SEM) ··· 49 45 * If the lock pointer matches the BLOCKER_TYPE_MASK, return 50 46 * without writing anything. 51 47 */ 52 - if (WARN_ON_ONCE(lock_ptr & BLOCKER_TYPE_MASK)) 48 + if (lock_ptr & BLOCKER_TYPE_MASK) 53 49 return; 54 50 55 51 WRITE_ONCE(current->blocker, lock_ptr | type); ··· 57 53 58 54 static inline void hung_task_clear_blocker(void) 59 55 { 60 - WARN_ON_ONCE(!READ_ONCE(current->blocker)); 61 - 62 56 WRITE_ONCE(current->blocker, 0UL); 63 57 } 64 58