ipmi: ssif_bmc: change log level to dbg in irq callback

Long-running tests indicate that this logging can occasionally disrupt
timing and lead to request/response corruption.

Irq handler need to be executed as fast as possible,
most I2C slave IRQ implementations are byte-level, logging here
can significantly affect transfer behavior and timing. It is recommended
to use dev_dbg() for these messages.

Fixes: dd2bc5cc9e25 ("ipmi: ssif_bmc: Add SSIF BMC driver")
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>
Message-ID: <20260403090603.3988423-4-zhangjian.3032@bytedance.com>
Signed-off-by: Corey Minyard <corey@minyard.net>

authored by

Jian Zhang and committed by

Corey Minyard 1 month ago c9c99b7b 1d38e849

+9 -9

1 changed file

expand all

drivers

char

ipmi

ssif_bmc.c

+9 -9

drivers/char/ipmi/ssif_bmc.c

··· 569 569 len = ssif_bmc->request.len + part->length; 570 570 /* Do the bound check here, not allow the request len exceed 254 bytes */ 571 571 if (len > IPMI_SSIF_PAYLOAD_MAX) { 572 - dev_warn(&ssif_bmc->client->dev, 572 + dev_dbg(&ssif_bmc->client->dev, 573 573 "Warn: Request exceeded 254 bytes, aborting"); 574 574 /* Request too long, aborting */ 575 575 ssif_bmc->aborting = true; ··· 615 615 ssif_bmc->state == SSIF_START || 616 616 ssif_bmc->state == SSIF_REQ_RECVING || 617 617 ssif_bmc->state == SSIF_RES_SENDING) { 618 - dev_warn(&ssif_bmc->client->dev, 618 + dev_dbg(&ssif_bmc->client->dev, 619 619 "Warn: %s unexpected READ REQUESTED in state=%s\n", 620 620 __func__, state_to_string(ssif_bmc->state)); 621 621 ssif_bmc->state = SSIF_ABORTING; ··· 624 624 625 625 } else if (ssif_bmc->state == SSIF_SMBUS_CMD) { 626 626 if (!supported_read_cmd(ssif_bmc->part_buf.smbus_cmd)) { 627 - dev_warn(&ssif_bmc->client->dev, "Warn: Unknown SMBus read command=0x%x", 627 + dev_dbg(&ssif_bmc->client->dev, "Warn: Unknown SMBus read command=0x%x", 628 628 ssif_bmc->part_buf.smbus_cmd); 629 629 ssif_bmc->aborting = true; 630 630 } ··· 659 659 ssif_bmc->state == SSIF_START || 660 660 ssif_bmc->state == SSIF_REQ_RECVING || 661 661 ssif_bmc->state == SSIF_SMBUS_CMD) { 662 - dev_warn(&ssif_bmc->client->dev, 662 + dev_dbg(&ssif_bmc->client->dev, 663 663 "Warn: %s unexpected READ PROCESSED in state=%s\n", 664 664 __func__, state_to_string(ssif_bmc->state)); 665 665 ssif_bmc->state = SSIF_ABORTING; ··· 684 684 } else if (ssif_bmc->state == SSIF_START || 685 685 ssif_bmc->state == SSIF_REQ_RECVING || 686 686 ssif_bmc->state == SSIF_RES_SENDING) { 687 - dev_warn(&ssif_bmc->client->dev, 687 + dev_dbg(&ssif_bmc->client->dev, 688 688 "Warn: %s unexpected WRITE REQUEST in state=%s\n", 689 689 __func__, state_to_string(ssif_bmc->state)); 690 690 ssif_bmc->state = SSIF_ABORTING; ··· 699 699 { 700 700 if (ssif_bmc->state == SSIF_READY || 701 701 ssif_bmc->state == SSIF_RES_SENDING) { 702 - dev_warn(&ssif_bmc->client->dev, 702 + dev_dbg(&ssif_bmc->client->dev, 703 703 "Warn: %s unexpected WRITE RECEIVED in state=%s\n", 704 704 __func__, state_to_string(ssif_bmc->state)); 705 705 ssif_bmc->state = SSIF_ABORTING; ··· 709 709 710 710 } else if (ssif_bmc->state == SSIF_SMBUS_CMD) { 711 711 if (!supported_write_cmd(ssif_bmc->part_buf.smbus_cmd)) { 712 - dev_warn(&ssif_bmc->client->dev, "Warn: Unknown SMBus write command=0x%x", 712 + dev_dbg(&ssif_bmc->client->dev, "Warn: Unknown SMBus write command=0x%x", 713 713 ssif_bmc->part_buf.smbus_cmd); 714 714 ssif_bmc->aborting = true; 715 715 } ··· 738 738 ssif_bmc->state == SSIF_START || 739 739 ssif_bmc->state == SSIF_SMBUS_CMD || 740 740 ssif_bmc->state == SSIF_ABORTING) { 741 - dev_warn(&ssif_bmc->client->dev, 741 + dev_dbg(&ssif_bmc->client->dev, 742 742 "Warn: %s unexpected SLAVE STOP in state=%s\n", 743 743 __func__, state_to_string(ssif_bmc->state)); 744 744 ssif_bmc->state = SSIF_READY; ··· 805 805 break; 806 806 807 807 default: 808 - dev_warn(&ssif_bmc->client->dev, "Warn: Unknown i2c slave event\n"); 808 + dev_dbg(&ssif_bmc->client->dev, "Warn: Unknown i2c slave event\n"); 809 809 break; 810 810 } 811 811

Configure Feed

Configure Feed