tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

NFSD: add cb opcode to WARN_ONCE on failed callback

It helps to know what kind of callback happened that triggered the
WARN_ONCE in nfsd4_cb_done() function in diagnosing what can set
an uncommon state where both cb_status and tk_status are set at
the same time.

Signed-off-by: Olga Kornievskaia <okorniev@redhat.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

authored by

Olga Kornievskaia and committed by
Chuck Lever cb80ecf7 1b3e26a5

+3 -2
+3 -2
fs/nfsd/nfs4callback.c
··· 1396 1396 return; 1397 1397 1398 1398 if (cb->cb_status) { 1399 - WARN_ONCE(task->tk_status, "cb_status=%d tk_status=%d", 1400 - cb->cb_status, task->tk_status); 1399 + WARN_ONCE(task->tk_status, 1400 + "cb_status=%d tk_status=%d cb_opcode=%d", 1401 + cb->cb_status, task->tk_status, cb->cb_ops->opcode); 1401 1402 task->tk_status = cb->cb_status; 1402 1403 } 1403 1404