Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ASoC: dt-bindings: samsung-i2s: add specific compatibles for existing SoC

Samsung Exynos SoC reuses several devices from older designs, thus
historically we kept the old (block's) compatible only. This works fine
and there is no bug here, however guidelines expressed in
Documentation/devicetree/bindings/writing-bindings.rst state that:
1. Compatibles should be specific.
2. We should add new compatibles in case of bugs or features.

Add compatibles specific to each SoC in front of all old-SoC-like
compatibles.

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Lee Jones <lee@kernel.org>
Acked-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20231108104343.24192-12-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

+13 -8
+1 -1
Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
··· 85 85 }; 86 86 87 87 i2s@11440000 { 88 - compatible = "samsung,exynos7-i2s"; 88 + compatible = "samsung,exynos5433-i2s", "samsung,exynos7-i2s"; 89 89 reg = <0x11440000 0x100>; 90 90 dmas = <&adma 0>, <&adma 2>; 91 91 dma-names = "tx", "rx";
+12 -7
Documentation/devicetree/bindings/sound/samsung-i2s.yaml
··· 44 44 frequencies supported by Exynos7 I2S and 7.1 channel TDM support 45 45 for playback and capture TDM (Time division multiplexing) to allow 46 46 transfer of multiple channel audio data on single data line. 47 - enum: 48 - - samsung,s3c6410-i2s 49 - - samsung,s5pv210-i2s 50 - - samsung,exynos5420-i2s 51 - - samsung,exynos7-i2s 52 - - samsung,exynos7-i2s1 53 - - tesla,fsd-i2s 47 + oneOf: 48 + - enum: 49 + - samsung,s3c6410-i2s 50 + - samsung,s5pv210-i2s 51 + - samsung,exynos5420-i2s 52 + - samsung,exynos7-i2s 53 + - samsung,exynos7-i2s1 54 + - tesla,fsd-i2s 55 + - items: 56 + - enum: 57 + - samsung,exynos5433-i2s 58 + - const: samsung,exynos7-i2s 54 59 55 60 '#address-cells': 56 61 const: 1