tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ecryptfs: Drop TODO comment in ecryptfs_derive_iv

Remove the TODO from 2006. eCryptfs is generally not receiving new
features and changing the IV derivation is only likely to happen to
address security concerns in the future.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
[tyhicks: Add the reasoning to the commit message]
Signed-off-by: Tyler Hicks <code@tyhicks.com>

authored by

Thorsten Blum and committed by
Tyler Hicks cd3b3094 c8717a7f

-4
-4
fs/ecryptfs/crypto.c
··· 89 89 ecryptfs_printk(KERN_DEBUG, "root iv:\n"); 90 90 ecryptfs_dump_hex(crypt_stat->root_iv, crypt_stat->iv_bytes); 91 91 } 92 - /* TODO: It is probably secure to just cast the least 93 - * significant bits of the root IV into an unsigned long and 94 - * add the offset to that rather than go through all this 95 - * hashing business. -Halcrow */ 96 92 memcpy(src, crypt_stat->root_iv, crypt_stat->iv_bytes); 97 93 memset((src + crypt_stat->iv_bytes), 0, 16); 98 94 snprintf((src + crypt_stat->iv_bytes), 16, "%lld", offset);