Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/i915/scaler: Fix WA_14011503117

This introduces and uses a variable id which is just uninitialized.
What really needs to be used is the scaler_id.

Fixes: 73309ed9d598 ("drm/i915/display: WA_14011503117")
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Nemesa Garg <nemesa.garg@intel.com>
Link: https://lore.kernel.org/r/20250806030856.3514127-1-suraj.kandpal@intel.com

+3 -2
+3 -2
drivers/gpu/drm/i915/display/skl_scaler.c
··· 959 959 struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc); 960 960 const struct intel_crtc_scaler_state *scaler_state = 961 961 &crtc_state->scaler_state; 962 - int id; 963 962 964 963 if (!scaler_state && scaler_state->scaler_id == -1) 965 964 return; 966 965 967 - intel_de_write_fw(display, SKL_PS_ECC_STAT(crtc->pipe, id), 1); 966 + intel_de_write_fw(display, 967 + SKL_PS_ECC_STAT(crtc->pipe, scaler_state->scaler_id), 968 + 1); 968 969 intel_de_write(display, XELPD_DISPLAY_ERR_FATAL_MASK, 0); 969 970 }