tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/msm/dpu: drop VBIF_NRT handling

The second VBIF instance, VBIF_NRT, is only used for the separate inline
rotator block. It is unsupported by the DPU driver and will require a
separate driver (or separate instance of the DPU device).

The only possible user of VBIF_NRT is writeback on MSM8996, however
writeback on that platform is currently unsupported and it's not worth
keeping extra complexity for the sake of that single legacy platform.

None of the hardware catalogs entries actually declare VBIF_NRT, so it
is left in its default state.

Stop pretending that DPU driver cares about VBIF_NRT and drop it.

Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/707773/
Link: https://lore.kernel.org/r/20260227-drop-vbif-nrt-v1-1-2b97d0438182@oss.qualcomm.com

Dmitry Baryshkov cfb64b09 82159db4

-17
-1
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h
··· 286 286 287 287 enum dpu_vbif { 288 288 VBIF_RT, 289 - VBIF_NRT, 290 289 VBIF_MAX, 291 290 }; 292 291
-14
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
··· 1357 1357 return ret; 1358 1358 } 1359 1359 1360 - dpu_kms->vbif[VBIF_NRT] = msm_ioremap_mdss(mdss_dev, 1361 - dpu_kms->pdev, 1362 - "vbif_nrt_phys"); 1363 - if (IS_ERR(dpu_kms->vbif[VBIF_NRT])) { 1364 - dpu_kms->vbif[VBIF_NRT] = NULL; 1365 - DPU_DEBUG("VBIF NRT is not defined"); 1366 - } 1367 - 1368 1360 return 0; 1369 1361 } 1370 1362 ··· 1380 1388 DPU_ERROR("vbif register memory map failed: %d\n", ret); 1381 1389 dpu_kms->vbif[VBIF_RT] = NULL; 1382 1390 return ret; 1383 - } 1384 - 1385 - dpu_kms->vbif[VBIF_NRT] = msm_ioremap_quiet(pdev, "vbif_nrt"); 1386 - if (IS_ERR(dpu_kms->vbif[VBIF_NRT])) { 1387 - dpu_kms->vbif[VBIF_NRT] = NULL; 1388 - DPU_DEBUG("VBIF NRT is not defined"); 1389 1391 } 1390 1392 1391 1393 return 0;
-2
drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
··· 24 24 switch (idx) { 25 25 case VBIF_RT: 26 26 return "VBIF_RT"; 27 - case VBIF_NRT: 28 - return "VBIF_NRT"; 29 27 default: 30 28 return "??"; 31 29 }