Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

perf: Fix refcount warning on event->mmap_count increment

When calling refcount_inc(&event->mmap_count) inside perf_mmap_rb(), the
following warning is triggered:

refcount_t: addition on 0; use-after-free.
WARNING: lib/refcount.c:25

PoC:

struct perf_event_attr attr = {0};
int fd = syscall(__NR_perf_event_open, &attr, 0, -1, -1, 0);
mmap(NULL, 0x3000, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
int victim = syscall(__NR_perf_event_open, &attr, 0, -1, fd,
PERF_FLAG_FD_OUTPUT);
mmap(NULL, 0x3000, PROT_READ | PROT_WRITE, MAP_SHARED, victim, 0);

This occurs when creating a group member event with the flag
PERF_FLAG_FD_OUTPUT. The group leader should be mmap-ed and then mmap-ing
the event triggers the warning.

Since the event has copied the output_event in perf_event_set_output(),
event->rb is set. As a result, perf_mmap_rb() calls
refcount_inc(&event->mmap_count) when event->mmap_count = 0.

Disallow the case when event->mmap_count = 0. This also prevents two
events from updating the same user_page.

Fixes: 448f97fba901 ("perf: Convert mmap() refcounts to refcount_t")
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Will Rosenberg <whrosenb@asu.edu>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://patch.msgid.link/20260119184956.801238-1-whrosenb@asu.edu

authored by

Will Rosenberg and committed by
Peter Zijlstra
d06bf78e 24d479d2

+9
+9
kernel/events/core.c
··· 6997 6997 if (data_page_nr(event->rb) != nr_pages) 6998 6998 return -EINVAL; 6999 6999 7000 + /* 7001 + * If this event doesn't have mmap_count, we're attempting to 7002 + * create an alias of another event's mmap(); this would mean 7003 + * both events will end up scribbling the same user_page; 7004 + * which makes no sense. 7005 + */ 7006 + if (!refcount_read(&event->mmap_count)) 7007 + return -EBUSY; 7008 + 7000 7009 if (refcount_inc_not_zero(&event->rb->mmap_count)) { 7001 7010 /* 7002 7011 * Success -- managed to mmap() the same buffer