tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/amd/display: Revert "drm/amd/display: Add a check for idle power optimization"

Revert commit 434cf7af492f ("drm/amd/display: Add a check for idle power optimization")
Because it cause Freesync and S4 regression

Reviewed-by: Aric Cyr <aric.cyr@amd.com>
Acked-by: Tom Chung <chiahsuan.chung@amd.com>
Signed-off-by: Sung Joon Kim <sungkim@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

authored by

Sung Joon Kim and committed by
Alex Deucher d0a767f7 061863e5

+1 -21
+1 -19
drivers/gpu/drm/amd/display/dc/core/dc.c
··· 4908 4908 4909 4909 void dc_allow_idle_optimizations(struct dc *dc, bool allow) 4910 4910 { 4911 - if (dc->debug.disable_idle_power_optimizations || 4912 - (dc->caps.ips_support && dc->config.disable_ips)) 4911 + if (dc->debug.disable_idle_power_optimizations) 4913 4912 return; 4914 4913 4915 4914 if (dc->clk_mgr != NULL && dc->clk_mgr->funcs->is_smu_present) ··· 4920 4921 4921 4922 if (dc->hwss.apply_idle_power_optimizations && dc->hwss.apply_idle_power_optimizations(dc, allow)) 4922 4923 dc->idle_optimizations_allowed = allow; 4923 - } 4924 - 4925 - bool dc_is_idle_power_optimized(struct dc *dc) 4926 - { 4927 - uint32_t idle_state = 0; 4928 - 4929 - if (dc->debug.disable_idle_power_optimizations) 4930 - return false; 4931 - 4932 - if (dc->hwss.get_idle_state) 4933 - idle_state = dc->hwss.get_idle_state(dc); 4934 - 4935 - if ((idle_state & DMUB_IPS1_ALLOW_MASK) || 4936 - (idle_state & DMUB_IPS2_ALLOW_MASK)) 4937 - return true; 4938 - 4939 - return false; 4940 4924 } 4941 4925 4942 4926 /* set min and max memory clock to lowest and highest DPM level, respectively */
-1
drivers/gpu/drm/amd/display/dc/dc.h
··· 2317 2317 struct dc_cursor_attributes *cursor_attr); 2318 2318 2319 2319 void dc_allow_idle_optimizations(struct dc *dc, bool allow); 2320 - bool dc_is_idle_power_optimized(struct dc *dc); 2321 2320 2322 2321 /* set min and max memory clock to lowest and highest DPM level, respectively */ 2323 2322 void dc_unlock_memory_clock_frequency(struct dc *dc);
-1
drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c
··· 352 352 funcs->init_reg_offsets = dmub_srv_dcn35_regs_init; 353 353 354 354 funcs->is_hw_powered_up = dmub_dcn35_is_hw_powered_up; 355 - funcs->should_detect = dmub_dcn35_should_detect; 356 355 break; 357 356 358 357 default: