Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PCI: dwc: Rework the error print of dw_pcie_wait_for_link()

For the cases where the link cannot come up later i.e., when LTSSM is not
in Detect.{Quiet/Active} or Poll.{Active/Compliance} states,
dw_pcie_wait_for_link() should log an error.

So promote dev_info() to dev_err(), reword the error log to make it clear
and also print the LTSSM state to aid debugging.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Tested-by: Richard Zhu <hongxing.zhu@nxp.com>
Tested-by: Vincent Guittot <vincent.guittot@linaro.org>
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
Link: https://patch.msgid.link/20260120-pci-dwc-suspend-rework-v4-4-2f32d5082549@oss.qualcomm.com

authored by

Manivannan Sadhasivam and committed by
Manivannan Sadhasivam
d266f63b 36dd677f

+2 -1
+2 -1
drivers/pci/controller/dwc/pcie-designware.c
··· 787 787 return -EIO; 788 788 } 789 789 790 - dev_info(pci->dev, "Phy link never came up\n"); 790 + dev_err(pci->dev, "Link failed to come up. LTSSM: %s\n", 791 + dw_pcie_ltssm_status_string(ltssm)); 791 792 return -ETIMEDOUT; 792 793 } 793 794