tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

hwspinlock: omap: Discard pm_runtime_put() return value

Failing driver probe due to pm_runtime_put() returning a negative value
is not particularly useful.

Returning an error code from pm_runtime_put() merely means that it has
not queued up a work item to check whether or not the device can be
suspended and there are many perfectly valid situations in which that
can happen, like after writing "on" to the devices' runtime PM "control"
attribute in sysfs for one example. It also happens when the kernel
has been configured with CONFIG_PM unset.

Accordingly, update omap_hwspinlock_probe() to simply discard the
return value of pm_runtime_put().

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Bjorn Andersson <andersson@kernel.org>
Link: https://patch.msgid.link/883243465.0ifERbkFSE@rafael.j.wysocki

Rafael J. Wysocki d33976be 7b8de72b

+1 -3
+1 -3
drivers/hwspinlock/omap_hwspinlock.c
··· 101 101 * runtime PM will make sure the clock of this module is 102 102 * enabled again iff at least one lock is requested 103 103 */ 104 - ret = pm_runtime_put(&pdev->dev); 105 - if (ret < 0) 106 - return ret; 104 + pm_runtime_put(&pdev->dev); 107 105 108 106 /* one of the four lsb's must be set, and nothing else */ 109 107 if (hweight_long(i & 0xf) != 1 || i > 8)