Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

crypto: testmgr - remove panic_on_fail

The cryptomgr.panic_on_fail=1 kernel command-line parameter is not very
useful now that the tests have been fixed to WARN on failure, since
developers can just use panic_on_warn=1 instead. There's no need for a
special option just for the crypto self-tests. Remove it.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

Eric Biggers and committed by
Herbert Xu
d469eaed 3357b6c9

+3 -7
+3 -7
crypto/testmgr.c
··· 45 45 module_param(notests, bool, 0644); 46 46 MODULE_PARM_DESC(notests, "disable crypto self-tests"); 47 47 48 - static bool panic_on_fail; 49 - module_param(panic_on_fail, bool, 0444); 50 - 51 48 #ifdef CONFIG_CRYPTO_MANAGER_EXTRA_TESTS 52 49 static bool noextratests; 53 50 module_param(noextratests, bool, 0644); ··· 5851 5854 5852 5855 test_done: 5853 5856 if (rc) { 5854 - if (fips_enabled || panic_on_fail) { 5857 + if (fips_enabled) { 5855 5858 fips_fail_notify(); 5856 - panic("alg: self-tests for %s (%s) failed in %s mode!\n", 5857 - driver, alg, 5858 - fips_enabled ? "fips" : "panic_on_fail"); 5859 + panic("alg: self-tests for %s (%s) failed in fips mode!\n", 5860 + driver, alg); 5859 5861 } 5860 5862 pr_warn("alg: self-tests for %s using %s failed (rc=%d)", 5861 5863 alg, driver, rc);