tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

USB: ehci-fsl: Return valid error in ehci_fsl_setup_phy

ehci_fsl_setup_phy is supposed to return an int, but had a void return
value in the case of controller_ver being invalid.

Introduced by commit 3735ba8db8e6 ("powerpc/usb: fix bug of CPU hang
when missing USB PHY clock"), which missed one return.

Signed-off-by: Ben Collins <ben.c@servergy.com>
Cc: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Ben Collins and committed by
Linus Torvalds d479c911 e2a666d5

+1 -1
+1 -1
drivers/usb/host/ehci-fsl.c
··· 222 222 223 223 if (pdata->controller_ver < 0) { 224 224 dev_warn(hcd->self.controller, "Could not get controller version\n"); 225 - return; 225 + return -ENODEV; 226 226 } 227 227 228 228 portsc = ehci_readl(ehci, &ehci->regs->port_status[port_offset]);