tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: ti: tusb1210: Don't check for write errors when powering on

On some platforms, like Intel Merrifield, the writing values during power on
may timeout:

tusb1210 dwc3.0.auto.ulpi: error -110 writing val 0x41 to reg 0x80
phy phy-dwc3.0.auto.ulpi.0: phy poweron failed --> -110
dwc3 dwc3.0.auto: error -ETIMEDOUT: failed to initialize core
dwc3: probe of dwc3.0.auto failed with error -110

which effectively fails the probe of the USB controller.
Drop the check as it was before the culprit commit (see Fixes tag).

Fixes: 09a3512681b3 ("phy: ti: tusb1210: Improve ulpi_read()/_write() error checking")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: Ferry Toth <fntoth@gmail.com>
Link: https://lore.kernel.org/r/20220613160848.82746-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Andy Shevchenko and committed by
Vinod Koul d4a0a189 18b3eb79

+3 -2
+3 -2
drivers/phy/ti/phy-tusb1210.c
··· 105 105 msleep(TUSB1210_RESET_TIME_MS); 106 106 107 107 /* Restore the optional eye diagram optimization value */ 108 - return tusb1210_ulpi_write(tusb, TUSB1210_VENDOR_SPECIFIC2, 109 - tusb->vendor_specific2); 108 + tusb1210_ulpi_write(tusb, TUSB1210_VENDOR_SPECIFIC2, tusb->vendor_specific2); 109 + 110 + return 0; 110 111 } 111 112 112 113 static int tusb1210_power_off(struct phy *phy)