Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

cgroup: replace use of system_wq with system_percpu_wq

Currently if a user enqueue a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistentcy cannot be addressed without refactoring the API.

system_wq is a per-CPU worqueue, yet nothing in its name tells about that
CPU affinity constraint, which is very often not required by users. Make
it clear by adding a system_percpu_wq.

queue_work() / queue_delayed_work() mod_delayed_work() will now use the
new per-cpu wq: whether the user still stick on the old name a warn will
be printed along a wq redirect to the new one.

This patch add the new system_percpu_wq except for mm, fs and net
subsystem, whom are handled in separated patches.

The old wq will be kept for a few release cylces.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

authored by

Marco Crivellari and committed by
Tejun Heo
d6256771 222f83d5

+1 -1
+1 -1
kernel/cgroup/cgroup.c
··· 124 124 /* 125 125 * cgroup destruction makes heavy use of work items and there can be a lot 126 126 * of concurrent destructions. Use a separate workqueue so that cgroup 127 - * destruction work items don't end up filling up max_active of system_wq 127 + * destruction work items don't end up filling up max_active of system_percpu_wq 128 128 * which may lead to deadlock. 129 129 */ 130 130 static struct workqueue_struct *cgroup_destroy_wq;