tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mlxbf_gige: stop PHY during open() error paths

The mlxbf_gige_open() routine starts the PHY as part of normal
initialization. The mlxbf_gige_open() routine must stop the
PHY during its error paths.

Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")
Signed-off-by: David Thompson <davthompson@nvidia.com>
Reviewed-by: Asmaa Mnebhi <asmaa@nvidia.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

David Thompson and committed by
David S. Miller d6c30c5a c04f7dfe

+4 -1
+4 -1
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
··· 157 157 158 158 err = mlxbf_gige_tx_init(priv); 159 159 if (err) 160 - goto free_irqs; 160 + goto phy_deinit; 161 161 err = mlxbf_gige_rx_init(priv); 162 162 if (err) 163 163 goto tx_deinit; ··· 184 184 185 185 tx_deinit: 186 186 mlxbf_gige_tx_deinit(priv); 187 + 188 + phy_deinit: 189 + phy_stop(phydev); 187 190 188 191 free_irqs: 189 192 mlxbf_gige_free_irqs(priv);