tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

sched/topology: Remove redundant dl_clear_root_domain call

We completely clean and restore root domains bandwidth accounting after
every root domains change, so the dl_clear_root_domain() call in
partition_sched_domains_locked() is redundant.

Remove it.

Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Waiman Long <llong@redhat.com>
Reviewed-by: Shrikanth Hegde <sshegde@linux.ibm.com>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Tested-by: Waiman Long <longman@redhat.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Link: https://lore.kernel.org/r/Z9MRtcX4tz4tcLRR@jlelli-thinkpadt14gen4.remote.csb

authored by

Juri Lelli and committed by
Peter Zijlstra d735bab3 2ff899e3

+1 -14
+1 -14
kernel/sched/topology.c
··· 2720 2720 for (i = 0; i < ndoms_cur; i++) { 2721 2721 for (j = 0; j < n && !new_topology; j++) { 2722 2722 if (cpumask_equal(doms_cur[i], doms_new[j]) && 2723 - dattrs_equal(dattr_cur, i, dattr_new, j)) { 2724 - struct root_domain *rd; 2725 - 2726 - /* 2727 - * This domain won't be destroyed and as such 2728 - * its dl_bw->total_bw needs to be cleared. 2729 - * Tasks contribution will be then recomputed 2730 - * in function dl_update_tasks_root_domain(), 2731 - * dl_servers contribution in function 2732 - * dl_restore_server_root_domain(). 2733 - */ 2734 - rd = cpu_rq(cpumask_any(doms_cur[i]))->rd; 2735 - dl_clear_root_domain(rd); 2723 + dattrs_equal(dattr_cur, i, dattr_new, j)) 2736 2724 goto match1; 2737 - } 2738 2725 } 2739 2726 /* No match - a current sched domain not in new doms_new[] */ 2740 2727 detach_destroy_domains(doms_cur[i]);