tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

scripts/dtc: dtx_diff: remove broken example from help text

dtx_diff suggests to use <(...) syntax to pipe two inputs into it, but
this has never worked: The /proc/self/fds/... paths passed by the shell
will fail the `[ -f "${dtx}" ] && [ -r "${dtx}" ]` check in compile_to_dts,
but even with this check removed, the function cannot work: hexdump will
eat up the DTB magic, making the subsequent dtc call fail, as a pipe
cannot be rewound.

Simply remove this broken example, as there is already an alternative one
that works fine.

Fixes: 10eadc253ddf ("dtc: create tool to diff device trees")
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reviewed-by: Frank Rowand <frank.rowand@sony.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220113081918.10387-1-matthias.schiffer@ew.tq-group.com

authored by

Matthias Schiffer and committed by
Rob Herring d8adf5b9 af35a8b5

+2 -6
+2 -6
scripts/dtc/dtx_diff
··· 59 59 or '/include/' to be processed. 60 60 61 61 If DTx_1 and DTx_2 are in different architectures, then this script 62 - may not work since \${ARCH} is part of the include path. Two possible 63 - workarounds: 64 - 65 - `basename $0` \\ 66 - <(ARCH=arch_of_dtx_1 `basename $0` DTx_1) \\ 67 - <(ARCH=arch_of_dtx_2 `basename $0` DTx_2) 62 + may not work since \${ARCH} is part of the include path. The following 63 + workaround can be used: 68 64 69 65 `basename $0` ARCH=arch_of_dtx_1 DTx_1 >tmp_dtx_1.dts 70 66 `basename $0` ARCH=arch_of_dtx_2 DTx_2 >tmp_dtx_2.dts