tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ASoC: codecs: wcd938x: Drop no-op ADC2_BCS Disable Switch

The "ADC2_BCS Disable Switch" control does basically nothing: sets field
in driver's private data structure which is never read again to
configure hardware. Drop the control as it has no effect.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://msgid.link/r/20240523124808.42923-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Krzysztof Kozlowski and committed by
Mark Brown d8e5fa78 fe243a54

-28
-28
sound/soc/codecs/wcd938x.c
··· 206 206 bool comp1_enable; 207 207 bool comp2_enable; 208 208 bool ldoh; 209 - bool bcs_dis; 210 209 }; 211 210 212 211 static const SNDRV_CTL_TLVD_DECLARE_DB_MINMAX(ear_pa_gain, 600, -1800); ··· 1649 1650 return 1; 1650 1651 } 1651 1652 1652 - static int wcd938x_bcs_get(struct snd_kcontrol *kcontrol, 1653 - struct snd_ctl_elem_value *ucontrol) 1654 - { 1655 - struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); 1656 - struct wcd938x_priv *wcd938x = snd_soc_component_get_drvdata(component); 1657 - 1658 - ucontrol->value.integer.value[0] = wcd938x->bcs_dis; 1659 - 1660 - return 0; 1661 - } 1662 - 1663 - static int wcd938x_bcs_put(struct snd_kcontrol *kcontrol, 1664 - struct snd_ctl_elem_value *ucontrol) 1665 - { 1666 - struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); 1667 - struct wcd938x_priv *wcd938x = snd_soc_component_get_drvdata(component); 1668 - 1669 - if (wcd938x->bcs_dis == ucontrol->value.integer.value[0]) 1670 - return 0; 1671 - 1672 - wcd938x->bcs_dis = ucontrol->value.integer.value[0]; 1673 - 1674 - return 1; 1675 - } 1676 - 1677 1653 static const char * const tx_mode_mux_text_wcd9380[] = { 1678 1654 "ADC_INVALID", "ADC_HIFI", "ADC_LO_HIF", "ADC_NORMAL", "ADC_LP", 1679 1655 }; ··· 2669 2695 wcd938x_get_swr_port, wcd938x_set_swr_port), 2670 2696 SOC_SINGLE_EXT("LDOH Enable Switch", SND_SOC_NOPM, 0, 1, 0, 2671 2697 wcd938x_ldoh_get, wcd938x_ldoh_put), 2672 - SOC_SINGLE_EXT("ADC2_BCS Disable Switch", SND_SOC_NOPM, 0, 1, 0, 2673 - wcd938x_bcs_get, wcd938x_bcs_put), 2674 2698 2675 2699 SOC_SINGLE_TLV("ADC1 Volume", WCD938X_ANA_TX_CH1, 0, 20, 0, analog_gain), 2676 2700 SOC_SINGLE_TLV("ADC2 Volume", WCD938X_ANA_TX_CH2, 0, 20, 0, analog_gain),