tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

objtool: Fix NULL printf() '%s' argument in builtin-check.c:save_argv()

It's probably not the best idea to pass a string pointer to printf()
right after confirming said pointer is NULL. Fix the typo and use
argv[i] instead.

Fixes: c5995abe1547 ("objtool: Improve error handling")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
Link: https://lore.kernel.org/r/a814ed8b08fb410be29498a20a5fbbb26e907ecf.1742952512.git.jpoimboe@kernel.org
Closes: https://lore.kernel.org/20250326103854.309e3c60@canb.auug.org.au

authored by

Josh Poimboeuf and committed by
Ingo Molnar d9a595c3 05026ea0

+1 -1
+1 -1
tools/objtool/builtin-check.c
··· 238 238 for (int i = 0; i < argc; i++) { 239 239 orig_argv[i] = strdup(argv[i]); 240 240 if (!orig_argv[i]) { 241 - WARN_GLIBC("strdup(%s)", orig_argv[i]); 241 + WARN_GLIBC("strdup(%s)", argv[i]); 242 242 exit(1); 243 243 } 244 244 };