tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: phy: realtek: get rid of magic numbers in rtl8201_config_intr()

Replace the magic numbers with defines. Register names were obtained from
publicly available documentation[1]. This should make it clear what's going
on in the code.

1. RTL8201F/RTL8201FL/RTL8201FN Rev. 1.4 Datasheet
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
Reviewed-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Nicolai Buchwitz nb@tipi-net.de
Link: https://patch.msgid.link/20260406201222.1043396-1-olek2@wp.pl
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Aleksander Jan Bajkowski and committed by
Jakub Kicinski dbc2bb4e f81f4e79

+12 -3
+12 -3
drivers/net/phy/realtek/realtek_main.c
··· 22 22 #include "../phylib.h" 23 23 #include "realtek.h" 24 24 25 + #define RTL8201F_IER_PAGE 0x07 25 26 #define RTL8201F_IER 0x13 27 + #define RTL8201F_IER_LINK BIT(13) 28 + #define RTL8201F_IER_DUPLEX BIT(12) 29 + #define RTL8201F_IER_ANERR BIT(11) 30 + #define RTL8201F_IER_MASK (RTL8201F_IER_ANERR | \ 31 + RTL8201F_IER_DUPLEX | \ 32 + RTL8201F_IER_LINK) 26 33 27 34 #define RTL8201F_ISR 0x1e 28 35 #define RTL8201F_ISR_ANERR BIT(15) ··· 356 349 if (err) 357 350 return err; 358 351 359 - val = BIT(13) | BIT(12) | BIT(11); 360 - err = phy_write_paged(phydev, 0x7, RTL8201F_IER, val); 352 + val = RTL8201F_IER_MASK; 353 + err = phy_write_paged(phydev, RTL8201F_IER_PAGE, 354 + RTL8201F_IER, val); 361 355 } else { 362 356 val = 0; 363 - err = phy_write_paged(phydev, 0x7, RTL8201F_IER, val); 357 + err = phy_write_paged(phydev, RTL8201F_IER_PAGE, 358 + RTL8201F_IER, val); 364 359 if (err) 365 360 return err; 366 361