tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

si4713-i2c: avoid potential buffer overflow on si4713

While compiling it with Fedora 15, I noticed this issue:

inlined from ‘si4713_write_econtrol_string’ at drivers/media/radio/si4713-i2c.c:1065:24:
arch/x86/include/asm/uaccess_32.h:211:26: error: call to ‘copy_from_user_overflow’ declared with attribute error: copy_from_user() buffer size is not provably correct

Cc: stable@kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Acked-by: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
Acked-by: Eduardo Valentin <edubezval@gmail.com>
Reviewed-by: Eugene Teo <eugeneteo@kernel.sg>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Mauro Carvalho Chehab and committed by
Linus Torvalds dc6b8450 524196d2

+2 -2
+2 -2
drivers/media/radio/si4713-i2c.c
··· 1033 1033 char ps_name[MAX_RDS_PS_NAME + 1]; 1034 1034 1035 1035 len = control->size - 1; 1036 - if (len > MAX_RDS_PS_NAME) { 1036 + if (len < 0 || len > MAX_RDS_PS_NAME) { 1037 1037 rval = -ERANGE; 1038 1038 goto exit; 1039 1039 } ··· 1057 1057 char radio_text[MAX_RDS_RADIO_TEXT + 1]; 1058 1058 1059 1059 len = control->size - 1; 1060 - if (len > MAX_RDS_RADIO_TEXT) { 1060 + if (len < 0 || len > MAX_RDS_RADIO_TEXT) { 1061 1061 rval = -ERANGE; 1062 1062 goto exit; 1063 1063 }