tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: nfc: llcp: Add lock when modifying device list

The device list needs its associated lock held when modifying it, or the
list could become corrupted, as syzbot discovered.

Reported-and-tested-by: syzbot+c1d0a03d305972dbbe14@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=c1d0a03d305972dbbe14
Signed-off-by: Jeremy Cline <jeremy@jcline.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Fixes: 6709d4b7bc2e ("net: nfc: Fix use-after-free caused by nfc_llcp_find_local")
Link: https://lore.kernel.org/r/20230908235853.1319596-1-jeremy@jcline.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Jeremy Cline and committed by
Jakub Kicinski dfc7f7a9 8957261c

+2
+2
net/nfc/llcp_core.c
··· 1636 1636 timer_setup(&local->sdreq_timer, nfc_llcp_sdreq_timer, 0); 1637 1637 INIT_WORK(&local->sdreq_timeout_work, nfc_llcp_sdreq_timeout_work); 1638 1638 1639 + spin_lock(&llcp_devices_lock); 1639 1640 list_add(&local->list, &llcp_devices); 1641 + spin_unlock(&llcp_devices_lock); 1640 1642 1641 1643 return 0; 1642 1644 }