tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: ti: icssg-prueth: Omit a variable reassignment in prueth_netdev_init()

An error code was assigned to a variable and checked accordingly.
This value was passed to a dev_err_probe() call in an if branch.
This function is documented in the way that the same value is returned.
Thus delete two redundant variable reassignments.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: https://patch.msgid.link/71f7daa3-d4f4-4753-aae8-67040fc8297d@web.de
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

authored by

Markus Elfring and committed by
Paolo Abeni e0665df8 d550d63d

+2 -4
+1 -2
drivers/net/ethernet/ti/icssg/icssg_prueth.c
··· 1250 1250 } else if (of_phy_is_fixed_link(eth_node)) { 1251 1251 ret = of_phy_register_fixed_link(eth_node); 1252 1252 if (ret) { 1253 - ret = dev_err_probe(prueth->dev, ret, 1254 - "failed to register fixed-link phy\n"); 1253 + dev_err_probe(prueth->dev, ret, "failed to register fixed-link phy\n"); 1255 1254 goto free; 1256 1255 } 1257 1256
+1 -2
drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
··· 818 818 } else if (of_phy_is_fixed_link(eth_node)) { 819 819 ret = of_phy_register_fixed_link(eth_node); 820 820 if (ret) { 821 - ret = dev_err_probe(prueth->dev, ret, 822 - "failed to register fixed-link phy\n"); 821 + dev_err_probe(prueth->dev, ret, "failed to register fixed-link phy\n"); 823 822 goto free; 824 823 } 825 824