tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Octeontx2-af: Fix pci_alloc_irq_vectors() return value check

In cgx_probe() when pci_alloc_irq_vectors() fails the error value will
be negative and that check is sufficient.

err = pci_alloc_irq_vectors(pdev, nvec, nvec, PCI_IRQ_MSIX);
if (err < 0 || err != nvec) {
...
}

When pci_alloc_irq_vectors() fail to allocate nvec number of vectors,
-ENOSPC is returned, so it would be safe to remove the check that
compares err with nvec.

Suggested-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251015090117.1557870-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Harshit Mogalapalli and committed by
Jakub Kicinski e1048520 38c31c26

+1 -1
+1 -1
drivers/net/ethernet/marvell/octeontx2/af/cgx.c
··· 1994 1994 1995 1995 nvec = pci_msix_vec_count(cgx->pdev); 1996 1996 err = pci_alloc_irq_vectors(pdev, nvec, nvec, PCI_IRQ_MSIX); 1997 - if (err < 0 || err != nvec) { 1997 + if (err < 0) { 1998 1998 dev_err(dev, "Request for %d msix vectors failed, err %d\n", 1999 1999 nvec, err); 2000 2000 goto err_release_regions;