tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

gpio: aspeed-sgpio: Change the macro to support deferred probe

Use module_platform_driver() to replace module_platform_driver_probe().
The former utilizes platform_driver_register(), which allows the driver to
defer probing when it doesn't acquire the necessary resources due to probe
order. In contrast, the latter uses __platform_driver_probe(), which
includes the comment "Note that this is incompatible with deferred
probing." Since our SGPIO driver requires access to the clock resource, the
former is more suitable.

Reviewed-by: Linus Walleij <linusw@kernel.org>
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Link: https://lore.kernel.org/r/20260123-upstream_sgpio-v2-1-69cfd1631400@aspeedtech.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

authored by

Billy Tsai and committed by
Bartosz Golaszewski e18533b0 09b174f1

+3 -2
+3 -2
drivers/gpio/gpio-aspeed-sgpio.c
··· 516 516 517 517 MODULE_DEVICE_TABLE(of, aspeed_sgpio_of_table); 518 518 519 - static int __init aspeed_sgpio_probe(struct platform_device *pdev) 519 + static int aspeed_sgpio_probe(struct platform_device *pdev) 520 520 { 521 521 u32 nr_gpios, sgpio_freq, sgpio_clk_div, gpio_cnt_regval, pin_mask; 522 522 const struct aspeed_sgpio_pdata *pdata; ··· 611 611 } 612 612 613 613 static struct platform_driver aspeed_sgpio_driver = { 614 + .probe = aspeed_sgpio_probe, 614 615 .driver = { 615 616 .name = KBUILD_MODNAME, 616 617 .of_match_table = aspeed_sgpio_of_table, 617 618 }, 618 619 }; 619 620 620 - module_platform_driver_probe(aspeed_sgpio_driver, aspeed_sgpio_probe); 621 + module_platform_driver(aspeed_sgpio_driver); 621 622 MODULE_DESCRIPTION("Aspeed Serial GPIO Driver");