tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/msm: Fix incorrect file name output in adreno_request_fw()

In adreno_request_fw() when debugging information is printed to the log
after firmware load, an incorrect filename is printed. 'newname' is used
instead of 'fwname', so prefix "qcom/" is being added to filename.
Looks like "copy-paste" mistake.

Fix this mistake by replacing 'newname' with 'fwname'.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 2c41ef1b6f7d ("drm/msm/adreno: deal with linux-firmware fw paths")
Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/602382/
Signed-off-by: Rob Clark <robdclark@chromium.org>

authored by

Aleksandr Mishin and committed by
Rob Clark e1936691 6f682942

+1 -1
+1 -1
drivers/gpu/drm/msm/adreno/adreno_gpu.c
··· 484 484 ret = request_firmware_direct(&fw, fwname, drm->dev); 485 485 if (!ret) { 486 486 DRM_DEV_INFO(drm->dev, "loaded %s from legacy location\n", 487 - newname); 487 + fwname); 488 488 adreno_gpu->fwloc = FW_LOCATION_LEGACY; 489 489 goto out; 490 490 } else if (adreno_gpu->fwloc != FW_LOCATION_UNKNOWN) {