tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

selftests/landlock: Remove invalid unix socket bind()

Remove bind() call on a client socket that doesn't make sense.
Since strlen(cli_un.sun_path) returns a random value depending on stack
garbage, that many uninitialized bytes are read from the stack as an
unix socket address. This creates random test failures due to the bind
address being invalid or already in use if the same stack value comes up
twice.

Fixes: f83d51a5bdfe ("selftests/landlock: Check IOCTL restrictions for named UNIX domain sockets")
Signed-off-by: Matthieu Buffet <matthieu@buffet.re>
Reviewed-by: Günther Noack <gnoack@google.com>
Link: https://lore.kernel.org/r/20251201003631.190817-1-matthieu@buffet.re
Signed-off-by: Mickaël Salaün <mic@digikod.net>

authored by

Matthieu Buffet and committed by
Mickaël Salaün e1a57c33 6685201e

-3
-3
tools/testing/selftests/landlock/fs_test.c
··· 4391 4391 cli_fd = socket(AF_UNIX, SOCK_STREAM, 0); 4392 4392 ASSERT_LE(0, cli_fd); 4393 4393 4394 - size = offsetof(struct sockaddr_un, sun_path) + strlen(cli_un.sun_path); 4395 - ASSERT_EQ(0, bind(cli_fd, (struct sockaddr *)&cli_un, size)); 4396 - 4397 4394 bzero(&cli_un, sizeof(cli_un)); 4398 4395 cli_un.sun_family = AF_UNIX; 4399 4396 strncpy(cli_un.sun_path, path, sizeof(cli_un.sun_path));