tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

stmmac: cleanup dead dependencies on STMMAC_PLATFORM and STMMAC_ETH in Kconfig

There are already 'if STMMAC_ETH' and 'STMMAC_PLATFORM'
conditions wrapping these config options, making the
'depends on' statements duplicate dependencies (dead code).

I propose leaving the outer 'if STMMAC_PLATFORM...endif' and
'if STMMAC_ETH...endif' conditions, and removing the
individual 'depends on' statements.

This dead code was found by kconfirm, a static analysis tool for Kconfig.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/20260402145858.240231-1-julianbraha@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Julian Braha and committed by
Jakub Kicinski e2f152c8 a9b46022

+3 -6
+3 -6
drivers/net/ethernet/stmicro/stmmac/Kconfig
··· 20 20 config STMMAC_SELFTESTS 21 21 bool "Support for STMMAC Selftests" 22 22 depends on INET 23 - depends on STMMAC_ETH 24 23 default n 25 24 help 26 25 This adds support for STMMAC Selftests using ethtool. Enable this ··· 28 29 29 30 config STMMAC_PLATFORM 30 31 tristate "STMMAC Platform bus support" 31 - depends on STMMAC_ETH 32 32 select MFD_SYSCON 33 33 default y 34 34 help ··· 334 336 config DWMAC_INTEL_PLAT 335 337 tristate "Intel dwmac support" 336 338 depends on OF && COMMON_CLK 337 - depends on STMMAC_ETH 338 339 help 339 340 Support for ethernet controllers on Intel SoCs 340 341 ··· 368 371 help 369 372 Support for ethernet controller on Visconti SoCs. 370 373 371 - endif 374 + endif # STMMAC_PLATFORM 372 375 373 376 config STMMAC_LIBPCI 374 377 tristate ··· 378 381 config DWMAC_INTEL 379 382 tristate "Intel GMAC support" 380 383 default X86 381 - depends on X86 && STMMAC_ETH && PCI 384 + depends on X86 && PCI 382 385 depends on COMMON_CLK 383 386 depends on ACPI 384 387 help ··· 417 420 If you have a controller with this interface, say Y or M here. 418 421 419 422 If unsure, say N. 420 - endif 423 + endif # STMMAC_ETH