Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

dmaengine: ioat: Drop redundant pci_enable_pcie_error_reporting()

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver. Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device. An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/20230307192655.874008-2-helgaas@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Bjorn Helgaas and committed by
Vinod Koul
e32622f8 8f6707d0

-6
-6
drivers/dma/ioat/init.c
··· 15 15 #include <linux/workqueue.h> 16 16 #include <linux/prefetch.h> 17 17 #include <linux/dca.h> 18 - #include <linux/aer.h> 19 18 #include <linux/sizes.h> 20 19 #include "dma.h" 21 20 #include "registers.h" ··· 1379 1380 if (is_skx_ioat(pdev)) 1380 1381 device->version = IOAT_VER_3_2; 1381 1382 err = ioat3_dma_probe(device, ioat_dca_enabled); 1382 - 1383 - if (device->version >= IOAT_VER_3_3) 1384 - pci_enable_pcie_error_reporting(pdev); 1385 1383 } else 1386 1384 return -ENODEV; 1387 1385 1388 1386 if (err) { 1389 1387 dev_err(dev, "Intel(R) I/OAT DMA Engine init failed\n"); 1390 - pci_disable_pcie_error_reporting(pdev); 1391 1388 return -ENODEV; 1392 1389 } 1393 1390 ··· 1406 1411 device->dca = NULL; 1407 1412 } 1408 1413 1409 - pci_disable_pcie_error_reporting(pdev); 1410 1414 ioat_dma_remove(device); 1411 1415 } 1412 1416