tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

usb: vhci-hcd: Switch to dev_err_probe() in probe path

Replace pr_err() calls in vhci_hcd_probe() with dev_err_probe(), to
simplify error handling a bit and improve consistency.

Acked-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Link: https://lore.kernel.org/r/20251008-vhci-hcd-cleanup-v2-1-b6acc4dd6e44@collabora.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Cristian Ciocaltea and committed by
Greg Kroah-Hartman e361b2bf 082c8dc1

+7 -9
+7 -9
drivers/usb/usbip/vhci_hcd.c
··· 1372 1372 * Our private data is also allocated automatically. 1373 1373 */ 1374 1374 hcd_hs = usb_create_hcd(&vhci_hc_driver, &pdev->dev, dev_name(&pdev->dev)); 1375 - if (!hcd_hs) { 1376 - pr_err("create primary hcd failed\n"); 1377 - return -ENOMEM; 1378 - } 1375 + if (!hcd_hs) 1376 + return dev_err_probe(&pdev->dev, -ENOMEM, "create primary hcd failed\n"); 1377 + 1379 1378 hcd_hs->has_tt = 1; 1380 1379 1381 1380 /* ··· 1382 1383 * Call the driver's reset() and start() routines. 1383 1384 */ 1384 1385 ret = usb_add_hcd(hcd_hs, 0, 0); 1385 - if (ret != 0) { 1386 - pr_err("usb_add_hcd hs failed %d\n", ret); 1386 + if (ret) { 1387 + dev_err_probe(&pdev->dev, ret, "usb_add_hcd hs failed\n"); 1387 1388 goto put_usb2_hcd; 1388 1389 } 1389 1390 1390 1391 hcd_ss = usb_create_shared_hcd(&vhci_hc_driver, &pdev->dev, 1391 1392 dev_name(&pdev->dev), hcd_hs); 1392 1393 if (!hcd_ss) { 1393 - ret = -ENOMEM; 1394 - pr_err("create shared hcd failed\n"); 1394 + ret = dev_err_probe(&pdev->dev, -ENOMEM, "create shared hcd failed\n"); 1395 1395 goto remove_usb2_hcd; 1396 1396 } 1397 1397 1398 1398 ret = usb_add_hcd(hcd_ss, 0, 0); 1399 1399 if (ret) { 1400 - pr_err("usb_add_hcd ss failed %d\n", ret); 1400 + dev_err_probe(&pdev->dev, ret, "usb_add_hcd ss failed\n"); 1401 1401 goto put_usb3_hcd; 1402 1402 } 1403 1403