tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/vc4: platform_get_irq_byname() returns an int

platform_get_irq_byname() will return a negative value if an error
happens, so it should be checked and not just passed directly into
devm_request_threaded_irq() hoping all will be ok.

Cc: Maxime Ripard <mripard@kernel.org>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: Maíra Canal <mcanal@igalia.com>
Cc: Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Simona Vetter <simona@ffwll.ch>
Cc: stable <stable@kernel.org>
Assisted-by: gkh_clanker_2000
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://patch.msgid.link/2026022339-cornflake-t-shirt-2471@gregkh
Signed-off-by: Maíra Canal <mcanal@igalia.com>

authored by

Greg Kroah-Hartman and committed by
Maíra Canal e597a809 21613f67

+10 -4
+10 -4
drivers/gpu/drm/vc4/vc4_hdmi.c
··· 2449 2449 int ret; 2450 2450 2451 2451 if (vc4_hdmi->variant->external_irq_controller) { 2452 - unsigned int hpd_con = platform_get_irq_byname(pdev, "hpd-connected"); 2453 - unsigned int hpd_rm = platform_get_irq_byname(pdev, "hpd-removed"); 2452 + int hpd = platform_get_irq_byname(pdev, "hpd-connected"); 2454 2453 2455 - ret = devm_request_threaded_irq(&pdev->dev, hpd_con, 2454 + if (hpd < 0) 2455 + return hpd; 2456 + 2457 + ret = devm_request_threaded_irq(&pdev->dev, hpd, 2456 2458 NULL, 2457 2459 vc4_hdmi_hpd_irq_thread, IRQF_ONESHOT, 2458 2460 "vc4 hdmi hpd connected", vc4_hdmi); 2459 2461 if (ret) 2460 2462 return ret; 2461 2463 2462 - ret = devm_request_threaded_irq(&pdev->dev, hpd_rm, 2464 + hpd = platform_get_irq_byname(pdev, "hpd-removed"); 2465 + if (hpd < 0) 2466 + return hpd; 2467 + 2468 + ret = devm_request_threaded_irq(&pdev->dev, hpd, 2463 2469 NULL, 2464 2470 vc4_hdmi_hpd_irq_thread, IRQF_ONESHOT, 2465 2471 "vc4 hdmi hpd disconnected", vc4_hdmi);