Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/amdgpu/mmhub3.0.2: add bounds checking for cid
The value should never exceed the array size as those
are the only values the hardware is expected to return,
but add checks anyway.
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 1441f52c7f6ae6553664aa9e3e4562f6fc2fe8ea)
Cc: stable@vger.kernel.org
+2
-1
+2
-1
drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_2.c
+2
-1
drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_2.c
···
108
108
"MMVM_L2_PROTECTION_FAULT_STATUS:0x%08X\n",
109
109
status);
110
110
111
-
mmhub_cid = mmhub_client_ids_v3_0_2[cid][rw];
111
+
mmhub_cid = cid < ARRAY_SIZE(mmhub_client_ids_v3_0_2) ?
112
+
mmhub_client_ids_v3_0_2[cid][rw] : NULL;
112
113
dev_err(adev->dev, "\t Faulty UTCL2 client ID: %s (0x%x)\n",
113
114
mmhub_cid ? mmhub_cid : "unknown", cid);
114
115
dev_err(adev->dev, "\t MORE_FAULTS: 0x%lx\n",