tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

[PATCH] x86-64/i386: Use common X86_PM_TIMER option and make it EMBEDDED

This makes x86-64 use the common X86_PM_TIMER Kconfig entry in drivers/acpi

And since PM timer is needed for correct timing on a lot of systems
now (e.g. AMD dual cores) and we often get bug reports from people
who forgot to set it make it depend on CONFIG_EMBEDDED. x86-64 had
this change before and it's a good thing.

I also fixed the description slightly to make this more clear.

Cc: len.brown@intel.com

Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

authored by

Andi Kleen and committed by
Linus Torvalds e78256b8 6070f9ec

+3 -20
-15
arch/x86_64/Kconfig
··· 354 354 as it is off-chip. You can find the HPET spec at 355 355 <http://www.intel.com/hardwaredesign/hpetspec.htm>. 356 356 357 - config X86_PM_TIMER 358 - bool "PM timer" if EMBEDDED 359 - depends on ACPI 360 - default y 361 - help 362 - Support the ACPI PM timer for time keeping. This is slow, 363 - but is useful on some chipsets without HPET on systems with more 364 - than one CPU. On a single processor or single socket multi core 365 - system it is normally not required. 366 - When the PM timer is active 64bit vsyscalls are disabled 367 - and should not be enabled (/proc/sys/kernel/vsyscall64 should 368 - not be changed). 369 - The kernel selects the PM timer only as a last resort, so it is 370 - useful to enable just in case. 371 - 372 357 config HPET_EMULATE_RTC 373 358 bool "Provide RTC interrupt" 374 359 depends on HPET_TIMER && RTC=y
+3 -5
drivers/acpi/Kconfig
··· 285 285 dump your ACPI DSDT table using /proc/acpi/dsdt. 286 286 287 287 config X86_PM_TIMER 288 - bool "Power Management Timer Support" 288 + bool "Power Management Timer Support" if EMBEDDED 289 289 depends on X86 290 - depends on !X86_64 291 290 default y 292 291 help 293 292 The Power Management Timer is available on all ACPI-capable, ··· 297 298 voltage scaling, unlike the commonly used Time Stamp Counter 298 299 (TSC) timing source. 299 300 300 - So, if you see messages like 'Losing too many ticks!' in the 301 - kernel logs, and/or you are using this on a notebook which 302 - does not yet have an HPET, you should say "Y" here. 301 + You should nearly always say Y here because many modern 302 + systems require this timer. 303 303 304 304 config ACPI_CONTAINER 305 305 tristate "ACPI0004,PNP0A05 and PNP0A06 Container Driver (EXPERIMENTAL)"